❇️ [source-S3] pass in AWS credentials from config when assuming a role #36482
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the previous setup, when a role is assumed, credentials are loaded only by boto3's env var loading logic, and not explicitly by the source connector. This meant, that the role assumption didn't work at all, when the credentials (access key ID and secret access key) were provided in the source configuration. Now explicitly passing the set values, both of these methods should work.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
marcosmarxm
changed the title
marcosmarxm
added
gl
team/db-dw-sources
|
Thanks for the contribution @imrehg I added it to the connector backlog as hope they can review in next sprints. |
evantahler
added
team/critical-connectors
and removed
team/db-dw-sources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the previous setup, when a role is assumed, credentials are loaded only by boto3's env var loading logic, and not explicitly by the source connector. This meant, that the role assumption didn't work at all, when the credentials (access key ID and secret access key) were provided in the source configuration.
Now explicitly passing the set values, both of these methods should work.
I've tested locally to set up an S3 source correctly with these changes, that previously failed.