You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2, because the migration to low-code CDK involves significant changes to the structure and implementation of the connector, but the complexity is managed by the declarative nature of the low-code CDK.
🧪 Relevant tests
No
🔍 Possible issues
Possible Bug: The OAuthAuthenticator is used across multiple streams, but there's no explicit handling or mention of token expiration and refresh logic beyond the initial setup. This could potentially lead to authentication failures if the token expires within a long-running sync.
Performance Concern: The current implementation does not specify any rate limiting handling. Given that the Primetric API has rate limits, this could lead to failed requests and incomplete data syncs.
Consider implementing a mechanism to handle token expiration and refresh for the OAuthAuthenticator. This ensures that the connector can handle long-running syncs without authentication issues. [important]
Implement rate limiting handling to respect the Primetric API's rate limits. This could be achieved by introducing a RateLimiter in the request configuration to avoid hitting the API too frequently. [important]
For better error handling, consider adding specific error handling strategies for HTTP error codes returned by the Primetric API. This can improve the robustness of the connector. [medium]
To enhance the connector's usability, consider adding more descriptive titles and descriptions in the connection_specification to guide users through the configuration process. [medium]
Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.
The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Migrating Source Primetric to Low-Code CDK
Closes airbytehq/airbyte-internal-issues#7029
How
Developed using (Configuration Based Source) low-code CDK
Recommended reading order
spec.yaml
manifest.yaml
schemas/*
Tests
Integration & Acceptance
🚨 User Impact 🚨