Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: Remove qa-engine in favor of connectors_qa #36591

Merged
merged 1 commit into from Mar 28, 2024

Conversation

natikgadzhi
Copy link
Contributor

What

@alafanechere implemented connectors_qa based on airbyte-ci like tooling, but we haven't removed qa-engine, which Augustin says is not used anymore.

This PR removes it. I'll also close all dependabot PRs that target qa-engine dependencies.

Why

The least code we have, the better.

@natikgadzhi natikgadzhi requested a review from a team as a code owner March 28, 2024 03:15
Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Mar 28, 2024 3:15am

@natikgadzhi natikgadzhi self-assigned this Mar 28, 2024
@natikgadzhi natikgadzhi enabled auto-merge (squash) March 28, 2024 03:15
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: connectors_qa did no replace qa_engine.
qa_engine was an automation to promoto connectors to cloud after checking some predicate (like qa_checks, which were run in connector_ops.qa_checks), it was not a package with check implementation per se.

@natikgadzhi natikgadzhi merged commit c613853 into master Mar 28, 2024
27 checks passed
@natikgadzhi natikgadzhi deleted the ng/airbyte-ci/qa-engine branch March 28, 2024 09:56
nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants