Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Mailchimp: fix acceptance tests #36601

Merged

Conversation

roman-yermilov-gl
Copy link
Collaborator

What

Upgrade CDK version to latest

@roman-yermilov-gl roman-yermilov-gl self-assigned this Mar 28, 2024
Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 0:11am

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Mar 28, 2024
@roman-yermilov-gl roman-yermilov-gl marked this pull request as ready for review March 28, 2024 12:08
@octavia-squidington-iv octavia-squidington-iv requested review from a team March 28, 2024 12:09
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, but otherwise lgtm

@@ -123,6 +123,7 @@ Now that you have set up the Mailchimp source connector, check out the following

| Version | Date | Pull Request | Subject |
| ------- | ---------- | -------------------------------------------------------- | -------------------------------------------------------------------------- |
| 1.2.0 | 2024-03-28 | [36600](https://github.com/airbytehq/airbyte/pull/36600) | Migrate to latest Airbyte-CDK. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please mention updating to use state record counts since it's more descriptive of the functional change

@roman-yermilov-gl roman-yermilov-gl merged commit 45dae2c into master Mar 28, 2024
36 of 37 checks passed
@roman-yermilov-gl roman-yermilov-gl deleted the ryermilov/source-mailchimp-fix-acceptance-tests branch March 28, 2024 18:26
nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/mailchimp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants