Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable spotbugs for CDK test and testFixtures submodules #36606

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented Mar 28, 2024

Some CDK submodules are failing their spotbugs checks. We're disabling those checks so we can publish the CDK

Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Mar 28, 2024 4:30pm

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Mar 28, 2024
@stephane-airbyte stephane-airbyte marked this pull request as ready for review March 28, 2024 16:29
@stephane-airbyte stephane-airbyte requested review from a team as code owners March 28, 2024 16:29
Copy link
Contributor Author

stephane-airbyte commented Mar 28, 2024

/publish-java-cdk

🕑 https://github.com/airbytehq/airbyte/actions/runs/8470541437
✅ Successfully published Java CDK version=0.28.17!

Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget to file an issue to track reverting this PR ASAP and assign it to someone.

@stephane-airbyte stephane-airbyte merged commit 552def8 into master Mar 28, 2024
31 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/03-28-disable_spotbugs_for_cdk_test_and_testfixtures_submodules branch March 28, 2024 18:17
nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
…36606)

Some CDK submodules are failing their spotbugs checks. We're disabling those checks so we can publish the CDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants