Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-intercom: ensure inline schemas, updated cdk, poetry (where possible) #36644

Merged
merged 22 commits into from May 10, 2024

Conversation

bleonard
Copy link
Contributor

@bleonard bleonard commented Mar 29, 2024

This was created from a set of automated scripts. In each case, not every update was needed for every connector, but overall here is what happened:

  • auto-schema update -s all description: added descriptions to json and inline schemas
  • connector-code migrate_to_yaml -c all --type source: migrates json schemas to connectors with a manifest
  • airbyte-ci connectors --name=<all modified connectors from above> migrate_to_base_image: makes sure that each is using a base docker image and updates docs
  • airbyte-ci connectors --name=<all modified connectors from above> migrate-to-poetry: moves connectors not already using poetry to do so and updates documentation
  • airbyte-ci connectors --name=<all modified connectors from above> up_to_date: updated the CDK to newer (0.80.0) version

The version number and changelogs were also bumped using the connector-code pulls command.

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 4:51pm

@bleonard bleonard changed the title source-intercom: schema descriptions source-intercom: ensure inline schemas, updated cdk, poetry (where possible) Apr 20, 2024
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamping

@bleonard
Copy link
Contributor Author

Getting this error on companies stream:

E           On schema['properties']['monthly_spend']['multipleOf']:
E               '1e-08'

But that's what was in the original json. maybe something about swithcing to yaml so it needs to be something else?

… github.com:airbytehq/airbyte into autopull/schema-descriptions-d2a8da/source-intercom
… github.com:airbytehq/airbyte into autopull/schema-descriptions-d2a8da/source-intercom
@lazebnyi lazebnyi merged commit 2453122 into master May 10, 2024
34 checks passed
@lazebnyi lazebnyi deleted the autopull/schema-descriptions-d2a8da/source-intercom branch May 10, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation autopull connectors/source/intercom test_parameters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants