Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Fix misspelling & missing punctuation mark in Pull Request Handbook Documentation. #36709

Merged
merged 1 commit into from Apr 1, 2024

Conversation

chelmerrox
Copy link
Contributor

@chelmerrox chelmerrox commented Mar 30, 2024

Problem:

There is a misspelling/typo and a missing punctuation in the Pull Request Handbook documentation. It can be found as the second last sentence under the first sub-heading: Pull Request Title Convention.

If you're code change is doing more than one change type at once we strongly recommend to break into multiple pull requests. It helps us to review and merge your contribution.

Fixes/Solution:

I've fixed the problems for more readability. I've replaced you're with your & added a comma after the word once.

If your code change is doing more than one change type at once, we strongly recommend to break into multiple pull requests. It helps us to review and merge your contribution.

Thanks in advance for you feedback!

Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2024 7:52am

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Even with a small change, I'm afraid you'd have to sign the CLA — and then we'll merge it.

@chelmerrox chelmerrox closed this Apr 1, 2024
@chelmerrox chelmerrox reopened this Apr 1, 2024
@natikgadzhi natikgadzhi merged commit fbfae42 into airbytehq:master Apr 1, 2024
14 checks passed
@natikgadzhi
Copy link
Contributor

Thank you again! Please don't hesitate to send more of those fixes, and/or ping me or anyone on the team if you need any help, @chelmerrox.

nurikk pushed a commit to nurikk/airbyte that referenced this pull request Apr 4, 2024
@chelmerrox chelmerrox deleted the patch-1 branch April 6, 2024 17:34
markcusack pushed a commit to markcusack/airbyte that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants