🐛 Destination MSSQL: fix issue with unicode symbols handling (ex.\u2028 showed as ?)

[Eugene (etsybaev)]

What

#3552 MSSQL Destination: Fix newline handling

How

Fixed MSSQL _airbyte_data field's type to support unicode.

This is for Microsoft SQL Server:
NVARCHAR is Unicode - 2 bytes per character, therefore max. of 1 billion characters; will handle East Asian, Arabic, Hebrew, Cyrillic etc. characters just fine.
VARCHAR is non-Unicode - 1 byte per character, max. capacity is 2 billion characters, but limited to the character set you're SQL Server is using, basically - no support for those languages mentioned before

Pre-merge Checklist

• Run integration tests
• Publish Docker images

Recommended reading order

1. test.java
2. component.ts
3. the rest

[Sherif A. Nada (sherifnada)]

Thanks for also updating the docs!

Once you've addressed the one comment, please bump the connector version like described here and update your PR with the new version: https://docs.airbyte.io/contributing-to-airbyte/building-new-connector#updating-a-connector

then publish the connector like described in the link.

[Sherif A. Nada (sherifnada)]

Christophe Duong (@ChristopheDuong) do we also need to do the same change in DBT i.e: writing strings as NVARCHARs?

[Christophe Duong (ChristopheDuong)]

Normalization is not handling MSSQL yet (so nothing to do there, unless implementing it...), otherwise I don't know how the mssql-dbt adapter plugin handle strings atm

[Sherif A. Nada (sherifnada)]

Eugene (@etsybaev) can you leave a comment in the code describing why NVARCHAR is used since we typically use VARCHAR?

[Eugene (etsybaev)]

Sherif A. Nada (@sherifnada) done. Added comment to code and documentation. Thanks

[Eugene (etsybaev)]

Hi Sherif A. Nada (@sherifnada).
I've updated versions but found it and updated in 2 places. Not sure if I also had to update it in airbyte-config/init/src/main/resources/seed/destination_definitions.yaml ?
Could you please also clarify what is the workflow for pushing images? the command "./tools/bin/check_images_exist.sh" works for me locally, but obviously failed in the build for this PR as the image has not been released globally. What are the next steps from my side?
Many thanks in advance!

[Sherif A. Nada (sherifnada)]

Eugene (@etsybaev) to publish an image you need to:

1. before bumping the image version, have a passing build and PR approvals
2. bump the image in Dockerfile, YAML, and JSON config files. The build will fail -- it's OK because we know the only change we made was version bump.
3. Run the /publish command
4. once publish is successful, merge to master

[Eugene (etsybaev)]

/test connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/894927119
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/894927119

[Eugene (etsybaev)]

/publish connector=connectors/destination-mssql

🕑 connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/894970067
✅ connectors/destination-mssql https://github.com/airbytehq/airbyte/actions/runs/894970067