Destinations: handle collisions between destination states #36768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Sweet. I'll put it in the queue after this #36620 |
|
lmk if you want me to wrap all the state stuff in try-catch return emptyMap(), I didn't add that to this pr but it's probably an easy change |
jbfbell
approved these changes
Apr 3, 2024
| } else { | ||
| OffsetDateTime.MIN | ||
| } | ||
| }.associate { |
edgao
force-pushed
the
edgao/destination_state_collision_handling
branch
from
479720c
to
6e15a4e
Compare
octavia-squidington-iii
added
area/connectors
|
/publish-java-cdk
|
octavia-squidington-iii
added
area/documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gisripa this should solve the dest-postgres dup state key thing, though... probably not worth merging until after the cdk stabilizes
also wraps destination-state-related code in try-catch, since we treat state as a best-effort thing.