🐛 [source-pinterest] Bump airbyte-cdk to get fix for state recordCount as float #36806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
brianjlai
changed the title
lazebnyi
approved these changes
Apr 4, 2024
lazebnyi
reviewed
Apr 4, 2024
| @@ -5,7 +5,7 @@ data: | |||
| connectorSubtype: api | |||
| connectorType: source | |||
| definitionId: 5cb7e5fe-38c2-11ec-8d3d-0242ac130003 | |||
| dockerImageTag: 1.3.0 | |||
| dockerImageTag: 1.3.1 | |||
There was a problem hiding this comment.
should we bump minor version instead of patch?
as we enable feature and not fix something
There was a problem hiding this comment.
This one is actually a bug fix, because we were already emitting record counts, but this fixes an issue w/ the record count logic, for some reason only a few sources were affected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolling the version since we were seeing the count bug crop up for pinterest when recordCount is emitted as an integer instead of a float.