-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Azure Blob Storage: support OAuth #36825
Source Azure Blob Storage: support OAuth #36825
Conversation
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
…oauth token [skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
This reverts commit 955e400.
[skip ci] Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -11,6 +11,26 @@ For information about how to use this connector within Airbyte, see [the documen | |||
* Poetry (~=1.7) - installation instructions [here](https://python-poetry.org/docs/#installation) | |||
|
|||
|
|||
### Generate new oauth token |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
airbyte-integrations/connectors/source-azure-blob-storage/source_azure_blob_storage/config.py
Show resolved
Hide resolved
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
This reverts commit 261912a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, this change broke my terraform code, should I modify my resource block to something like this?
configuration = {
credentials = {
auth_type = "storage_account_key"
azure_blob_storage_account_key = azurerm_storage_account.az_st.primary_access_key
}
azure_blob_storage_account_name = azurerm_storage_account.az_st.name
azure_blob_storage_container_name = azurerm_storage_container.az_cn.name
azure_blob_storage_endpoint = azurerm_storage_account.az_st.primary_blob_endpoint
streams = {...}
}
vs current terraform docs
configuration = {
azure_blob_storage_account_name = azurerm_storage_account.az_st.name
azure_blob_storage_container_name = azurerm_storage_container.az_cn.name
azure_blob_storage_account_key = azurerm_storage_account.az_st.primary_access_key
azure_blob_storage_endpoint = azurerm_storage_account.az_st.primary_blob_endpoint
streams = {...}
}
What
Resolve https://github.com/airbytehq/airbyte-internal-issues/issues/7049
How
config_migration
to align with new config format (moveazure_blob_storage_account_key
insidecredentials
object)Linked PR for cloud
https://github.com/airbytehq/airbyte-platform-internal/pull/11936