Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Azure Blob Storage: support OAuth #36825

Merged
merged 23 commits into from
Apr 15, 2024

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Apr 4, 2024

What

Resolve https://github.com/airbytehq/airbyte-internal-issues/issues/7049

How

  1. add support for oauth2.0
  2. add config_migration to align with new config format (move azure_blob_storage_account_key inside credentials object)

Linked PR for cloud

https://github.com/airbytehq/airbyte-platform-internal/pull/11936

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 11:28am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/azure-blob-storage labels Apr 4, 2024
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
…oauth token

[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
[skip ci]

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 self-assigned this Apr 5, 2024
@artem1205 artem1205 marked this pull request as ready for review April 5, 2024 16:29
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 requested a review from a team April 5, 2024 19:05
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -11,6 +11,26 @@ For information about how to use this connector within Airbyte, see [the documen
* Poetry (~=1.7) - installation instructions [here](https://python-poetry.org/docs/#installation)


### Generate new oauth token
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 merged commit e902607 into master Apr 15, 2024
28 checks passed
@artem1205 artem1205 deleted the artem1205/source-azure-blob-storage-oauth2.0 branch April 15, 2024 09:33
Copy link

@davidvaldez89d davidvaldez89d Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, this change broke my terraform code, should I modify my resource block to something like this?
configuration = {
credentials = {
auth_type = "storage_account_key"
azure_blob_storage_account_key = azurerm_storage_account.az_st.primary_access_key
}
azure_blob_storage_account_name = azurerm_storage_account.az_st.name
azure_blob_storage_container_name = azurerm_storage_container.az_cn.name
azure_blob_storage_endpoint = azurerm_storage_account.az_st.primary_blob_endpoint
streams = {...}
}

vs current terraform docs
configuration = {
azure_blob_storage_account_name = azurerm_storage_account.az_st.name
azure_blob_storage_container_name = azurerm_storage_container.az_cn.name
azure_blob_storage_account_key = azurerm_storage_account.az_st.primary_access_key
azure_blob_storage_endpoint = azurerm_storage_account.az_st.primary_blob_endpoint
streams = {...}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/azure-blob-storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants