Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate S3 regions from destination specs #36846

Merged
merged 3 commits into from Apr 5, 2024

Conversation

evantahler
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 4, 2024 11:28pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 4, 2024
@evantahler evantahler marked this pull request as ready for review April 4, 2024 23:08
@evantahler evantahler requested a review from a team as a code owner April 4, 2024 23:08
Copy link
Contributor

@JonsSpaghetti JonsSpaghetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@evantahler
Copy link
Contributor Author

evantahler commented Apr 5, 2024

As expected, the redshift tests pass (yay!), but databricks and iceberg don't. That's ok.

@evantahler evantahler changed the title Remove duplicate S3 regions Remove duplicate S3 regions from destination specs Apr 5, 2024
@evantahler
Copy link
Contributor Author

/approve-and-merge reason="the certified connectors pass tests, the community ones don't. That's OK"

@octavia-approvington
Copy link
Contributor

Approve this
imagine the commander saying yes

@octavia-approvington octavia-approvington merged commit 4342182 into master Apr 5, 2024
29 of 32 checks passed
@octavia-approvington octavia-approvington deleted the evan/dupe-s3-region branch April 5, 2024 21:24
markcusack pushed a commit to markcusack/airbyte that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants