Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source Marketo: migrate to low-code #36854

Merged
merged 9 commits into from
Apr 29, 2024

Conversation

askarpets
Copy link
Contributor

@askarpets askarpets commented Apr 5, 2024

What

Resolves: https://github.com/airbytehq/airbyte-internal-issues/issues/6957

How

Migrated streams activity_types, campaigns, lists, programs, and segmentations to low-code

Recommended reading order

  1. source_marketo/manifest.yaml

🚨 User Impact 🚨

No

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@askarpets askarpets self-assigned this Apr 5, 2024
Copy link

vercel bot commented Apr 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 5:08pm

@askarpets askarpets marked this pull request as ready for review April 8, 2024 15:38
@octavia-squidington-iv octavia-squidington-iv requested review from a team April 8, 2024 15:39
@askarpets askarpets added the low-code-migration This connector has been migrated to the low-code CDK label Apr 9, 2024
Copy link
Contributor

@alafanechere alafanechere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the streams migrated to low code behave correctly after running the regression test tool.

Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…-marketo-migrate-to-low-code

# Conflicts:
#	airbyte-integrations/connectors/source-marketo/metadata.yaml
#	airbyte-integrations/connectors/source-marketo/poetry.lock
#	airbyte-integrations/connectors/source-marketo/pyproject.toml
#	docs/integrations/sources/marketo.md
artem1205 and others added 2 commits April 29, 2024 17:02
Signed-off-by: Artem Inzhyyants <artem.inzhyyants@gmail.com>
@artem1205 artem1205 merged commit d211d41 into master Apr 29, 2024
35 checks passed
@artem1205 artem1205 deleted the source-marketo-migrate-to-low-code branch April 29, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/marketo low-code-migration This connector has been migrated to the low-code CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants