🐛 Source Salesforce: Add retry on REST API - #36885
Merged
Maxime Carbonneau-Leclerc (maxi297) merged 3 commits intoApr 8, 2024
Merged
Maxime Carbonneau-Leclerc (maxi297) merged 3 commits into
Maxime Carbonneau-Leclerc (maxi297) merged 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
| @@ -0,0 +1,39 @@ | |||
| # Copyright (c) 2024 Airbyte, Inc., all rights reserved. | |||
|
|
|||
| from datetime import datetime | |||
Contributor
Author
There was a problem hiding this comment.
This will clash with the source-salesforce part of https://github.com/airbytehq/airbyte/pull/36811/files#diff-82cd2ba6c00f795c829bdc86d1f039933a6168b6c1c6c1a4b89226c7b5c6bf67 but that shouldn't be too much of a hassle
Baz (bazarnov)
approved these changes
Apr 8, 2024
Maxime Carbonneau-Leclerc (maxi297)
changed the title
Maxime Carbonneau-Leclerc (maxi297)
deleted the
maxi297/salesforce_retry_on_fetch_next_page_for_chunk
branch
April 8, 2024 15:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have added retries on 406 on the https://github.com/airbytehq/airbyte/blob/4ac078b3826891ca33bbe394bdaa9891f0a28bf9/airbyte-integrations/connectors/source-salesforce/source_salesforce/rate_limiting.py#L30-L32. We are however still seeing syncs fail because of that. Checking all the cases on April 5th and 6th, there all occur in
_fetch_next_page_for_chunk. Hence, I'll blindly add retry there.This can be safely reverted