Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: write python connector dependencies to GCS #36892

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Apr 8, 2024

Closes https://github.com/airbytehq/airbyte-internal-issues/issues/7051

Make the publish pipeline upload a list of connector dependencies for each version to GCS.

E.G of produced artifacts.

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 8, 2024 11:03am

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere force-pushed the augustin/04-08-airbyte-ci_upload_python_connectors_dependencies_to_gcs branch from fc6e77c to 2b3365b Compare April 8, 2024 10:47
@alafanechere alafanechere force-pushed the augustin/04-08-airbyte-ci_upload_python_connectors_dependencies_to_gcs branch from 2b3365b to 74f7bd5 Compare April 8, 2024 11:03
@alafanechere alafanechere marked this pull request as ready for review April 8, 2024 11:05
@alafanechere alafanechere requested a review from a team as a code owner April 8, 2024 11:05
Copy link
Contributor

@girarda girarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :shipit:

nit: is there a reason not to write unit tests for airbyte-ci?

@alafanechere
Copy link
Contributor Author

looks good :shipit:

nit: is there a reason not to write unit tests for airbyte-ci?

@girarda there are unit tests but the coverage is not 💯 . The critical path is covered.

@alafanechere alafanechere merged commit 7c98ebe into master Apr 8, 2024
34 checks passed
@alafanechere alafanechere deleted the augustin/04-08-airbyte-ci_upload_python_connectors_dependencies_to_gcs branch April 8, 2024 16:17
markcusack pushed a commit to markcusack/airbyte that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants