Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏥Source Stripe: fix imports #36960

Merged
merged 2 commits into from Apr 10, 2024
Merged

🏥Source Stripe: fix imports #36960

merged 2 commits into from Apr 10, 2024

Conversation

askarpets
Copy link
Contributor

What

Remove unused import which causes PyAirbyte validation tests failure
from airbyte_cdk.sources.streams.concurrent.cursor import Comparable

Recommended reading order

  1. source.py

🚨 User Impact 🚨

No

Pre-merge Actions

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.

@askarpets askarpets self-assigned this Apr 10, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 10, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 9:25am

@octavia-squidington-iv octavia-squidington-iv requested review from a team April 10, 2024 09:00
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 10, 2024
lazebnyi
lazebnyi approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@lazebnyi lazebnyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@askarpets askarpets merged commit 09c59d0 into master Apr 10, 2024
31 checks passed
@askarpets askarpets deleted the source-stripe-fix-imports branch April 10, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazebnyi lazebnyi lazebnyi approved these changes

Assignees

@askarpets askarpets

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/stripe
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@askarpets @lazebnyi @octavia-squidington-iii