馃悰 Source Stripe: update to new Concurrent CDK interface #36964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌 1 Ignored Deployment
|
octavia-squidington-iii
added
connectors/source/stripe
area/connectors
octavia-squidington-iii
added
the
area/documentation
bazarnov
approved these changes
Apr 11, 2024
maxi297
deleted the
maxi297/update-stripe-with-new-concurrent-cdk-interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As #36811 was a breaking change, I wanted to update source-stripe so that anyone upping the CDK version would not have the issue.
How
Update the airbyte-cdk version and update the instantiation of ConcurrentCursor
馃毃 User Impact 馃毃
There should be no user changes as we are keeping the non-partitioned state for stripe. Given the weird incremental behaviors of the 30 days for events, it seems simpler to keep the sequential state.
Benefit: the next dev that picks up an issue for stripe won't have to resolve a breaking change they don't know about