Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix publish-java-cdk workflow on push-to-master #36975

Conversation

stephane-airbyte
Copy link
Contributor

@stephane-airbyte stephane-airbyte commented Apr 10, 2024

the publish-java-cdk on push-to-master wasn't working because the value of dry-run was set to true.
I'm also adding some debugging info so we know what the values of DRY_RUN and FORCE are

This was tested on my fork of the airbyte repo

@stephane-airbyte stephane-airbyte marked this pull request as ready for review April 10, 2024 19:30
Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 10, 2024 7:33pm

@stephane-airbyte stephane-airbyte requested a review from a team as a code owner April 10, 2024 19:30
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stephane-airbyte and the rest of your teammates on Graphite Graphite

@stephane-airbyte stephane-airbyte force-pushed the stephane/04-10-fix_publish-java-cdk_workflow_on_push-to-master branch from 383be21 to 85a2098 Compare April 10, 2024 19:32
@@ -77,6 +77,9 @@ jobs:
id: read-target-java-cdk-version
run: |
cdk_version=$(cat $CDK_VERSION_FILE_PATH | tr -d '\n')
echo "CDK_VERSION=$CDK_VERSION"
echo "FORCE=$FORCE"
echo "DRY_RUN=$DRY_RUN"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea

@stephane-airbyte stephane-airbyte merged commit f30f678 into master Apr 11, 2024
28 checks passed
@stephane-airbyte stephane-airbyte deleted the stephane/04-10-fix_publish-java-cdk_workflow_on_push-to-master branch April 11, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants