Run build with all supported python versions before publishing to pypi #3726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersions # Conflicts: # .github/workflows/publish-cdk-command.yml
midavadim
changed the title
davinchia
reviewed
Jun 1, 2021
There was a problem hiding this comment.
Looks good!
@midavadim did you do any manual test to double check this setup works fine? Want to quickly discuss that bit before we merge this in.
…r 'dry-run' input
|
@davinchia I tested it on my fork of airbyte. It looks fine (with exception for actual publishing task) |
davinchia
reviewed
Jun 1, 2021
davinchia
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
@midavadim great. there was a transient build error. I just restarted the build. feel free to merge this in after the build succeeds.
have 1 question, but it's non-blocking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Test build with different supported python versions
How
Added strategy with list of supported python versions [3.7.1, 3.7, 3.8, 3.9]
where 3.7.1 - is a minimal of 3.7.X versions supported in github actions
So build is running in different python envs.
Pre-merge Checklist
Recommended reading order