Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore(ci): Add version of format-checks that can run on forks #37356

Merged
merged 22 commits into from
Apr 23, 2024
Merged

Chore(ci): Add version of format-checks that can run on forks #37356

merged 22 commits into from
Apr 23, 2024

Conversation

aaronsteers
Copy link
Collaborator

@aaronsteers aaronsteers commented Apr 16, 2024 •
edited
Loading

Note: this PR is deprioritized in favor of:

Brought back as preferred over:

Since the new version is so much faster than the old version, I make a case in the above that we should just always run the unprivileged version.

image

This just adds a simple alternate execution of the format-check job. The alternate version will run on forks. The existing version, which requires 8-10 distinct secrets, will be skipped on forks.

For security/consistency reasons, the new check does not use airbyte-ci from the community member's local repo - instead installing from our own master branch (ignoring airbyte-ci from the forked repo).

@vercel Vercel
Copy link

vercel bot commented Apr 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 23, 2024 8:38pm

aaronsteers
aaronsteers commented Apr 16, 2024
View reviewed changes
.github/workflows/format_check.yml Outdated Show resolved Hide resolved
.github/workflows/format_check.yml Outdated Show resolved Hide resolved
@aaronsteers aaronsteers mentioned this pull request Apr 16, 2024
Closed
1 task
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label Apr 16, 2024
@aaronsteers
Copy link
Collaborator Author

Closing in favor of

We can re-open this if we decide to go a different direction.

@aaronsteers aaronsteers reopened this Apr 23, 2024
@aaronsteers aaronsteers marked this pull request as ready for review April 23, 2024 17:58
@aaronsteers aaronsteers requested a review from a team as a code owner April 23, 2024 17:58
@aaronsteers aaronsteers enabled auto-merge (squash) April 23, 2024 20:40
natikgadzhi
natikgadzhi approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with caveat that Augustin then cleans up the "consistency" piece when run-airbyte-ci is ready to run with optional tokens. Let's merge this!

@aaronsteers aaronsteers merged commit 68a8c70 into master Apr 23, 2024
31 checks passed
@aaronsteers aaronsteers deleted the aj/ci/allow-format-check-from-forks branch April 23, 2024 22:26
strosek pushed a commit that referenced this pull request Apr 24, 2024
@aaronsteers @strosek
CI: Add version of format-checks which can run on forks (#37356)
6dc3631
@alafanechere alafanechere mentioned this pull request Apr 30, 2024
Merged
FVidalCarneiro pushed a commit to AgiData/airbyte that referenced this pull request May 2, 2024
@aaronsteers @FVidalCarneiro
CI: Add version of format-checks which can run on forks (airbytehq#37356
526080b 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natikgadzhi natikgadzhi natikgadzhi approved these changes

Assignees
No one assigned
Labels
connectors/destination/pinecone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aaronsteers @natikgadzhi @octavia-squidington-iii