✨Source Klaviyo: add new streams #37370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
girarda
reviewed
May 2, 2024
| yield from super().read_records(sync_mode, cursor_field, stream_slice, stream_state) | ||
| yield from self.archived_stream.read_records(sync_mode, cursor_field, stream_slice, stream_state) | ||
| ) -> Iterable[Optional[Mapping[str, Any]]]: | ||
| return [{"archived": flag} for flag in (False, True)] |
There was a problem hiding this comment.
why does this need a custom component? why can't this be use a ListPartitionRouter?
There was a problem hiding this comment.
This is still needed for the CampaignsDetailed stream, which also requires additional requests to be performed in order to fetch fields which are not available in the main endpoint
girarda
reviewed
May 2, 2024
| if stream_slice.get("archived"): | ||
| archived_filter = "equals(archived,true)" | ||
| if "filter" in params and archived_filter not in params["filter"]: | ||
| params["filter"] = f"and({params['filter']},{archived_filter})" |
There was a problem hiding this comment.
I suspect this can also be done with interpolation. does this need to stay in Python?
There was a problem hiding this comment.
Same here - it is needed for the CampaignsDetailed stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolves https://github.com/airbytehq/product-request-backlog/issues/45
How
Added new streams with extended fields set:
campaigns_detailedlists_detailedReview guide
manifest.yamlstreams.pyUser Impact
No
Can this PR be safely reverted and rolled back?