Repository navigation
✨ Source Salesforce: improve rate limit error message during check command - #37376
Merged
Maxime Carbonneau-Leclerc (maxi297) merged 2 commits intoApr 17, 2024
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Maxime Carbonneau-Leclerc (maxi297)
requested review from
Baz (bazarnov) and
Erick Corona (strosek)
April 17, 2024 13:08
Octavia Squidington III (octavia-squidington-iii)
added
connectors/source/salesforce
area/connectors
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Baz (bazarnov)
approved these changes
Apr 17, 2024
Maxime Carbonneau-Leclerc (maxi297)
deleted the
issue-6990/improve-check-error-message-for-rate-limit
branch
April 17, 2024 14:21
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Addresses https://github.com/airbytehq/airbyte-internal-issues/issues/6990
How
By suffixing the message by something actionable for the user
User Impact
Until the platform is updated to display the error message return during the check, nothing will change. Once they do though, the message should be printed somewhere here:
Can this PR be safely reverted and rolled back?