Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Source Salesforce: improve rate limit error message during check command #37376

Merged
merged 2 commits into from Apr 17, 2024

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Apr 17, 2024

What

Addresses https://github.com/airbytehq/airbyte-internal-issues/issues/6990

How

By suffixing the message by something actionable for the user

User Impact

Until the platform is updated to display the error message return during the check, nothing will change. Once they do though, the message should be printed somewhere here:

image

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 1:14pm

@maxi297 maxi297 merged commit 2e00b2a into master Apr 17, 2024
35 checks passed
@maxi297 maxi297 deleted the issue-6990/improve-check-error-message-for-rate-limit branch April 17, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants