Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty commit. #3738

Merged
merged 4 commits into from
May 29, 2021
Merged

Empty commit. #3738

merged 4 commits into from
May 29, 2021

Conversation

davinchia
Copy link
Contributor

@davinchia davinchia commented May 29, 2021

What

This build isn't passing on my local, and on the build. I looked at the connector status page and the badge for source-file is red, which lines up with this failing for me.

The main problem seems to be the newer pip resolver isn't happy with our current dependencies. Changing this was enough to fix it.

> Task :airbyte-integrations:connectors:source-file:installTestReqs
	 ERROR: Exception:
	 Traceback (most recent call last):
	   File "/home/runner/work/airbyte/airbyte/airbyte-integrations/connectors/source-file/.venv/lib/python3.7/site-packages/pip/_internal/cli/base_command.py", line 180, in _main
	     status = self.run(options, args)
	   File "/home/runner/work/airbyte/airbyte/airbyte-integrations/connectors/source-file/.venv/lib/python3.7/site-packages/pip/_internal/cli/req_command.py", line 204, in wrapper
	     return func(self, options, args)
	   File "/home/runner/work/airbyte/airbyte/airbyte-integrations/connectors/source-file/.venv/lib/python3.7/site-packages/pip/_internal/commands/install.py", line 319, in run
	     reqs, check_supported_wheels=not options.target_dir
	   File "/home/runner/work/airbyte/airbyte/airbyte-integrations/connectors/source-file/.venv/lib/python3.7/site-packages/pip/_internal/resolution/resolvelib/resolver.py", line 128, in resolve
	     requirements, max_rounds=try_to_avoid_resolution_too_deep
	   File "/home/runner/work/airbyte/airbyte/airbyte-integrations/connectors/source-file/.venv/lib/python3.7/site-packages/pip/_vendor/resolvelib/resolvers.py", line 473, in resolve
	     state = resolution.resolve(requirements, max_rounds=max_rounds)
	   File "/home/runner/work/airbyte/airbyte/airbyte-integrations/connectors/source-file/.venv/lib/python3.7/site-packages/pip/_vendor/resolvelib/resolvers.py", line 384, in resolve
	     raise ResolutionTooDeep(max_rounds)
	 pip._vendor.resolvelib.resolvers.ResolutionTooDeep: 2000000

I got to this version by removing the constraint, running the install step, then using the installed version from pip list.

Pre-merge Checklist

  • Run integration tests

Recommended reading order

  1. setup.py

@davinchia
Copy link
Contributor Author

davinchia commented May 29, 2021

/test connector=source-file

🕑 source-file https://github.com/airbytehq/airbyte/actions/runs/887879141
❌ source-file https://github.com/airbytehq/airbyte/actions/runs/887879141

@davinchia
Copy link
Contributor Author

davinchia commented May 29, 2021

/test connector=source-file

🕑 source-file https://github.com/airbytehq/airbyte/actions/runs/887960028
❌ source-file https://github.com/airbytehq/airbyte/actions/runs/887960028

@davinchia
Copy link
Contributor Author

davinchia commented May 29, 2021

/test connector=source-file

🕑 source-file https://github.com/airbytehq/airbyte/actions/runs/888291714
❌ source-file https://github.com/airbytehq/airbyte/actions/runs/888291714

@davinchia
Copy link
Contributor Author

davinchia commented May 29, 2021

/test connector=source-file

🕑 source-file https://github.com/airbytehq/airbyte/actions/runs/888373423
❌ source-file https://github.com/airbytehq/airbyte/actions/runs/888373423

@davinchia
Copy link
Contributor Author

davinchia commented May 29, 2021

/test connector=source-file

🕑 source-file https://github.com/airbytehq/airbyte/actions/runs/888378950
✅ source-file https://github.com/airbytehq/airbyte/actions/runs/888378950

@davinchia davinchia requested a review from sherifnada May 29, 2021 14:37
@davinchia davinchia marked this pull request as ready for review May 29, 2021 14:38
@auto-assign auto-assign bot requested a review from jrhizor May 29, 2021 14:38
@davinchia davinchia removed the request for review from jrhizor May 29, 2021 14:38
@davinchia davinchia merged commit 65c04d6 into master May 29, 2021
@davinchia davinchia deleted the davinchia/test-source-file-build branch May 29, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant