Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE #37382

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Fix NPE #37382

merged 2 commits into from
Apr 17, 2024

Conversation

benmoriceau
Copy link
Contributor

What

Trace logging works but it should return in order to avoid an NPE

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@benmoriceau benmoriceau requested a review from a team as a code owner April 17, 2024 15:29
@vercel Vercel
Copy link

vercel bot commented Apr 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 3:44pm

@benmoriceau benmoriceau requested a review from edgao April 17, 2024 15:29
@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Apr 17, 2024
edgao
edgao approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you just wrap lines 63 - 73 in an else block? then we can remove all the return statements from the if blocks

@benmoriceau
Copy link
Contributor Author

can you just wrap lines 63 - 73 in an else block? then we can remove all the return statements from the if blocks

Done

@benmoriceau benmoriceau enabled auto-merge (squash) April 17, 2024 15:43
@benmoriceau benmoriceau merged commit a49f205 into master Apr 17, 2024
32 checks passed
@benmoriceau benmoriceau deleted the bmoric/fix-e2e-logging-npe branch April 17, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gosusnp gosusnp gosusnp approved these changes

@edgao edgao edgao approved these changes

@tryangul tryangul Awaiting requested review from tryangul

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/e2e-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benmoriceau @gosusnp @edgao @octavia-squidington-iii