Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Re-enable on-demand connector tests, allow execution on fork PRs #37395

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

aaronsteers
Copy link
Collaborator

@aaronsteers aaronsteers commented Apr 18, 2024

This adds back a /test command which can be run on PRs from forks.

  1. As with any similar approach, maintainers must do a code review ahead of running, to ensure that no malicious code is present.
  2. This workflow can be tested from this link: https://github.com/airbytehq/airbyte/actions/workflows/test-command.yml
    • You'll need to select the branch name aj/ci/re-enable-on-demand-connector-tests and then enter your PR number. (Comment ID is optional.)
    • If you want to test that functionality, use the ellipsis on a PR comment, copy its URL, and then scrape the comment ID from that last part of the URL.
  3. The workflow uploads the report as a GitHub CI Artifact, and the link to the artifact is embedded in the success comment.
    • Permissions are the same as usual for CI artifacts in our repo. If users cannot see them, then the link will not work for them.

Known issues

There's one failing test, which is the acceptance tests. It is complaining that it wants dockerhub credentials.

Separately, we should look into why this doesn't fail the workflow. It still returns a 0 exit code. Not part of the scope of this PR, but worth looking into.

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2024 10:09pm

@aaronsteers aaronsteers marked this pull request as ready for review April 22, 2024 19:06
@aaronsteers aaronsteers requested a review from a team as a code owner April 22, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant