Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[destination-astra] Add user-agent with caller name #37405

Merged
merged 15 commits into from
Apr 26, 2024

Conversation

hemidactylus
Copy link
Contributor

What

This PR adds a custom user-agent header field to the Astra DB Data API requests for aggregate usage statistics on the API side.

How

A new header is added in the AstraClient class, later used when issuing API command HTTP POST requests.

Review guide

destination_astra/astra_client.py

User Impact

No impact.

Can this PR be safely reverted and rolled back?

  • YES πŸ’š
  • NO ❌

Copy link

ellipsis-dev bot commented Apr 18, 2024

Your free trial has expired. To continue using Ellipsis, sign up at https://app.ellipsis.dev for $20/developer/month. If you have any questions, reach us at help@ellipsis.dev

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
airbyte-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Apr 26, 2024 6:01pm

@marcosmarxm marcosmarxm changed the title Add user-agent with caller name to Astra DB API requests [destination-astra] Add user-agent with caller name Apr 18, 2024
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hemidactylus can you bump the metadata version and add an entry in the changelog doc?

@hemidactylus
Copy link
Contributor Author

Hello, @marcosmarxm , I have bumped the connector version.
I also created a new airbyte-integrations/connectors/destination-astra/CHANGELOG.md with just the entry for this version (could not successfully investigate for the past changes in the commit history). I created it there after finding analogous files in some of the other connectors (e.g. airbyte-integrations/connectors/source-paypal-transaction/CHANGELOG.md), please let me know if this is what you meant.

Thank you!

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the changelog. You need to change the entry in the doc/integrations/destiination-astra.md file.

@marcosmarxm
Copy link
Member

marcosmarxm commented Apr 26, 2024

/format-fix

Format-fix job started... Check job output.

🟦 Job completed successfully (no changes).

@marcosmarxm marcosmarxm merged commit d84aa48 into airbytehq:master Apr 26, 2024
30 checks passed
@hemidactylus hemidactylus deleted the SL-user-agent-caller-name branch May 14, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/destination/astra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants