Clarify cdk parity test behavior #37407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @erohmensing and the rest of your teammates on |
This was referenced Apr 18, 2024
erohmensing
commented
Apr 18, 2024
Comment on lines
+304
to
+306
| if constructor == _concurrent_stream: | ||
| assert hasattr(stream._cursor, "state") | ||
| assert str(stream._cursor.state) == "{'__ab_full_refresh_state_message': True}" |
There was a problem hiding this comment.
Weirdly enough you can even check this in the beginning before the _read because the cursor has a constant state. but we can check it here at the end
Later when we switch to incremental checkpointing as it wants, if we give it the right cursor, we should get proper state messages with the right cursor
erohmensing
force-pushed
the
ella/fixtest
branch
from
c72651f
to
7cf265c
Compare
brianjlai
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to clarify that the check for "we get a state message from the stream" is not a temporary test behavior, it is permanent for the short term (in the long term, we'd want everything to work as concurrent does) as concurrent streams don't emit state messages, the concurrent source does.
Changes the test to check the state at the end of the test for concurrent sources, which is about the best we can do right now.