Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Source Facebook: migrate to CDK #3743

Merged
merged 42 commits into from
Jun 22, 2021
Merged

🎉 Source Facebook: migrate to CDK #3743

merged 42 commits into from
Jun 22, 2021

Commits on May 27, 2021

  1. Add all the missing fields except AdAsset and AdInsightsResult fields.

    @zestyping
    zestyping committed May 27, 2021
    Configuration menu
    Copy the full SHA
    7ffa945 View commit details
    Browse the repository at this point in the history

  2. Sort and format ad_insights.json with json.dumps(..., indent=2, sort_… 

    …keys=True).
    @zestyping
    zestyping committed May 27, 2021
    Configuration menu
    Copy the full SHA
    c202e21 View commit details
    Browse the repository at this point in the history

  3. Remove fields from ads_insights.json that have not been externally te… 

    …sted.
    @zestyping
    zestyping committed May 27, 2021
    Configuration menu
    Copy the full SHA
    5c61eaf View commit details
    Browse the repository at this point in the history

  4. Facebook source: Remove the offending "unique_conversions" and "conve… 

    …rsions" fields and add other available fields that have been tested and confirmed to work.
    @zestyping
    zestyping committed May 27, 2021
    Configuration menu
    Copy the full SHA
    69b1fb9 View commit details
    Browse the repository at this point in the history

  5. Update all the other ads_insights schemas for the various breakdowns.

    @zestyping
    zestyping committed May 27, 2021
    Configuration menu
    Copy the full SHA
    4d19cb2 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. format

    @eugene-kulak
    eugene-kulak committed May 28, 2021
    Configuration menu
    Copy the full SHA
    b9cea63 View commit details
    Browse the repository at this point in the history

  2. bump version, update changelog

    @eugene-kulak
    eugene-kulak committed May 28, 2021
    Configuration menu
    Copy the full SHA
    590f52c View commit details
    Browse the repository at this point in the history

Commits on May 29, 2021

  1. move to CDK implementation

    @eugene-kulak
    eugene-kulak committed May 29, 2021
    Configuration menu
    Copy the full SHA
    c98a6b0 View commit details
    Browse the repository at this point in the history

  2. proper spec dump

    @eugene-kulak
    eugene-kulak committed May 29, 2021
    Configuration menu
    Copy the full SHA
    26e49f5 View commit details
    Browse the repository at this point in the history

  3. fix read_records and api calls

    @eugene-kulak
    eugene-kulak committed May 29, 2021
    Configuration menu
    Copy the full SHA
    2bec98f View commit details
    Browse the repository at this point in the history

Commits on May 30, 2021

  1. fix call rate handling

    @eugene-kulak
    eugene-kulak committed May 30, 2021
    Configuration menu
    Copy the full SHA
    f9011da View commit details
    Browse the repository at this point in the history

  2. format

    @eugene-kulak
    eugene-kulak committed May 30, 2021
    Configuration menu
    Copy the full SHA
    8d4712c View commit details
    Browse the repository at this point in the history

  3. fix insight breakdowns

    @eugene-kulak
    eugene-kulak committed May 30, 2021
    Configuration menu
    Copy the full SHA
    cdcd72d View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. temp

    @eugene-kulak
    eugene-kulak committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    5f0f3e6 View commit details
    Browse the repository at this point in the history

  2. tmp

    @eugene-kulak
    eugene-kulak committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    b270f29 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into keu/facebook-call-r… 

    …ate-v2
    @eugene-kulak
    eugene-kulak committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    b1a610b View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2021

  1. Merge remote-tracking branch 'origin/master' into keu/facebook-call-r… 

    …ate-v2
    @eugene-kulak
    eugene-kulak committed Jun 13, 2021
    Configuration menu
    Copy the full SHA
    b4b34d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Merge remote-tracking branch 'origin/master' into keu/facebook-call-r… 

    …ate-v2
    @eugene-kulak
    eugene-kulak committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    cca7def View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. tmp

    @eugene-kulak
    eugene-kulak committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    5f8edd3 View commit details
    Browse the repository at this point in the history

  2. make insights streams configurable

    @eugene-kulak
    eugene-kulak committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    c384190 View commit details
    Browse the repository at this point in the history

  3. improve Async implementation using slices

    @eugene-kulak
    eugene-kulak committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    ce11d1a View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. fix tests

    @eugene-kulak
    eugene-kulak committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    67b3568 View commit details
    Browse the repository at this point in the history

  2. fix tests

    @eugene-kulak
    eugene-kulak committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    6467f12 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. fix tests and reading

    @eugene-kulak
    eugene-kulak committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    f9d7729 View commit details
    Browse the repository at this point in the history

  2. update with fixes for discovery

    @eugene-kulak
    eugene-kulak committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    238ffdf View commit details
    Browse the repository at this point in the history

  3. groom

    @eugene-kulak
    eugene-kulak committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    57b4648 View commit details
    Browse the repository at this point in the history

  4. update CHANGELOG.md

    @eugene-kulak
    eugene-kulak committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    e91bd9a View commit details
    Browse the repository at this point in the history

  5. format

    @eugene-kulak
    eugene-kulak committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    0aa7a3b View commit details
    Browse the repository at this point in the history

  6. update spec.json

    @eugene-kulak
    eugene-kulak committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    41412b3 View commit details
    Browse the repository at this point in the history

  7. minimize set of streams in configured_catalog.json

    @eugene-kulak
    eugene-kulak committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    be3b077 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/master' into keu/facebook-call-r… 

    …ate-v2
    @eugene-kulak
    eugene-kulak committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    33343ae View commit details
    Browse the repository at this point in the history

  9. update docs and move changelog

    @eugene-kulak
    eugene-kulak committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    a3cb28f View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2021

  1. fix date_range

    @eugene-kulak
    eugene-kulak committed Jun 20, 2021
    Configuration menu
    Copy the full SHA
    77c003f View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. fix state handling, filter out records that were not updated (insights)

    @eugene-kulak
    eugene-kulak committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    b4f2c8f View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. typos and SAT install

    @eugene-kulak
    eugene-kulak committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    9439e6d View commit details
    Browse the repository at this point in the history

  2. apply suggestions from @sherifnada

    @eugene-kulak
    eugene-kulak committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    403afd2 View commit details
    Browse the repository at this point in the history

  3. improve async jobs handling even more

    @eugene-kulak
    eugene-kulak committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    9f3d535 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into keu/facebook-call-r… 

    …ate-v2
    @eugene-kulak
    eugene-kulak committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    ba9c575 View commit details
    Browse the repository at this point in the history

  5. fix dependencies

    @eugene-kulak
    eugene-kulak committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    025daea View commit details
    Browse the repository at this point in the history

  6. fix filtration logic and improve logging

    @eugene-kulak
    eugene-kulak committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    31a3645 View commit details
    Browse the repository at this point in the history

  7. fix transient error with creatives stream

    @eugene-kulak
    eugene-kulak committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    9774108 View commit details
    Browse the repository at this point in the history

  8. bump version

    @eugene-kulak
    eugene-kulak committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    499e849 View commit details
    Browse the repository at this point in the history