Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source PayPal Transactions: update manifest.yaml to use the latest CDK version to fix the STATE for Incremental streams #37435

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Apr 19, 2024

What

Resolving: #37385

Having the old manifest version caused to use of the slice_end value instead of the most recent record observed, switching to the latest version of the CDK and manifest version - fixes the issue.

How

  • bumped the version from 0.50.2 to 0.80.0 for manifest.yaml

User Impact

Users that have experienced missing records, because the STATE value was far from the actual data value - should reset those streams and re-sync the data once again.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2024 1:15pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Apr 19, 2024
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 19, 2024
@bazarnov bazarnov marked this pull request as ready for review April 19, 2024 13:07
@octavia-squidington-iv octavia-squidington-iv requested review from a team April 19, 2024 13:09
Copy link
Contributor

@maxi297 maxi297 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always wondering if we should update the version at the root of manifest.yaml. The rest looks good to me!

@bazarnov
Copy link
Collaborator Author

I'm always wondering if we should update the version at the root of manifest.yaml. The rest looks good to me!

It's updated, take a look here: https://github.com/airbytehq/airbyte/pull/37435/files#diff-f3f66141f908f43848cb00a86d54a85976e83802173bdbc8cfb3b77b625aa014

@bazarnov bazarnov merged commit a6ed2ac into master Apr 19, 2024
37 of 38 checks passed
@bazarnov bazarnov deleted the baz/source/paypal-transactions/update-manifest-to-the-latest-version branch April 19, 2024 13:28
FVidalCarneiro pushed a commit to AgiData/airbyte that referenced this pull request Apr 19, 2024
…t CDK version to fix the STATE for Incremental streams (airbytehq#37435)
strosek pushed a commit that referenced this pull request Apr 24, 2024
…t CDK version to fix the STATE for Incremental streams (#37435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants