🐛 Source Salesforce and Stripe: Up CDK version to ensure config_errors are not translated as system_e… - #37448
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Octavia Squidington III (octavia-squidington-iii)
added
area/connectors
Octavia Squidington III (octavia-squidington-iii)
added
the
area/documentation
Maxime Carbonneau-Leclerc (maxi297)
changed the title
Maxime Carbonneau-Leclerc (maxi297)
requested a review
from Brian Lai (brianjlai)
April 19, 2024 20:54
Brian Lai (brianjlai)
approved these changes
Apr 19, 2024
Brian Lai (brianjlai)
left a comment
Brian Lai (brianjlai)
left a comment
Contributor
There was a problem hiding this comment.
i had a minor shock when i first saw 321 lines changed for a version bump, but all in the lock. I'm surprised dependencies changed that much in 1 day
…sure-config-errors-are-not-translated-to-system-error
Maxime Carbonneau-Leclerc (maxi297)
enabled auto-merge (squash)
April 19, 2024 21:23
Maxime Carbonneau-Leclerc (maxi297)
deleted the
maxi297/update-salesforce-and-stripe-to-ensure-config-errors-are-not-translated-to-system-error
branch
April 19, 2024 21:34
Erick Corona (strosek)
pushed a commit
that referenced
this pull request
Apr 24, 2024
…s are not translated as system_e… (#37448)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rrors
What
AirbyteTracedException in concurrent CDK are currently emitted as system_errors if they were triggered during partition generation or partition read.
How
Updating the CDK version to leverage [this change](#37443
User Impact
Errors should have the proper FailureType which means:
Can this PR be safely reverted and rolled back?