Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source Salesforce and Stripe: Up CDK version to ensure config_errors are not translated as system_e… #37448

Conversation

maxi297
Copy link
Contributor

@maxi297 maxi297 commented Apr 19, 2024

…rrors

What

AirbyteTracedException in concurrent CDK are currently emitted as system_errors if they were triggered during partition generation or partition read.

How

Updating the CDK version to leverage [this change](#37443

User Impact

Errors should have the proper FailureType which means:

  • Clearer error messages for the user
  • No pager alerts on config errors

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 19, 2024 9:15pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Apr 19, 2024
@maxi297 maxi297 changed the title Up CDK version to ensure config_errors are not translated as system_e… 🐛 Source Salesforce and Stripe: Up CDK version to ensure config_errors are not translated as system_e… Apr 19, 2024
@maxi297 maxi297 requested a review from brianjlai April 19, 2024 20:54
Copy link
Contributor

@brianjlai brianjlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had a minor shock when i first saw 321 lines changed for a version bump, but all in the lock. I'm surprised dependencies changed that much in 1 day

…sure-config-errors-are-not-translated-to-system-error
@maxi297 maxi297 enabled auto-merge (squash) April 19, 2024 21:23
@maxi297 maxi297 merged commit 7adfb7a into master Apr 19, 2024
34 checks passed
@maxi297 maxi297 deleted the maxi297/update-salesforce-and-stripe-to-ensure-config-errors-are-not-translated-to-system-error branch April 19, 2024 21:34
strosek pushed a commit that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/salesforce connectors/source/stripe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants