Add support refreshes to the metadata. #37472
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
| @@ -113,3 +113,5 @@ properties: | |||
| "$ref": AirbyteInternal.yaml | |||
| remoteRegistries: | |||
| "$ref": RemoteRegistries.yaml | |||
| supportsRefreshes: | |||
There was a problem hiding this comment.
This is the main change
There was a problem hiding this comment.
If you want this to appear in the registry you will have to add it to ConnectorRegistrySourceDefinition.yaml and ConnectorRegistryDestinationDefinition.yaml as well with defaults
There was a problem hiding this comment.
Done, I only added it to the destination since it is not needed for the source
There was a problem hiding this comment.
Is there some converter that are needed as well?
There was a problem hiding this comment.
Nice, basically any metadata fields will be copied over to the registry so long they are defined in both
| @@ -113,3 +113,5 @@ properties: | |||
| "$ref": AirbyteInternal.yaml | |||
| remoteRegistries: | |||
| "$ref": RemoteRegistries.yaml | |||
| supportsRefreshes: | |||
| type: boolean | |||
There was a problem hiding this comment.
Should we add a sane default?
| type: boolean | |
| type: boolean | |
| default: false | |
| @@ -38,18 +34,8 @@ class Config: | |||
|
|
|||
|
|
|||
| class JobType(BaseModel): | |||
| __root__: Literal[ | |||
| "get_spec", | |||
There was a problem hiding this comment.
I have a feeling CI will get mad since it looks like these were not run through the formatter.
I think you can run
airbyte-ci format fix python
unless something has changed in the last 3 months.
There was a problem hiding this comment.
Done, It didn't changed any file:
| @@ -113,3 +113,5 @@ properties: | |||
| "$ref": AirbyteInternal.yaml | |||
| remoteRegistries: | |||
| "$ref": RemoteRegistries.yaml | |||
| supportsRefreshes: | |||
There was a problem hiding this comment.
If you want this to appear in the registry you will have to add it to ConnectorRegistrySourceDefinition.yaml and ConnectorRegistryDestinationDefinition.yaml as well with defaults
What
Add the support refreshes to the metadata.
How
Add a new fields in
ConnectorMetadataDefinitionV0.yaml. 2 test files (valid and invalid) have been added. The other files are auto generated.Review guide
User Impact
Can this PR be safely reverted and rolled back?