Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: add a contribution guide #37533

Merged

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented Apr 24, 2024

Add a contribution guide to airbyte-ci to help introduce Airbyters to the code base.
The markdown view is preferred for review :D

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 24, 2024 2:31pm

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere marked this pull request as ready for review April 24, 2024 13:27
@alafanechere alafanechere requested a review from a team as a code owner April 24, 2024 13:27
Copy link
Contributor

@bnchrch bnchrch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work. I particularly liked how you broke out technologies and design goals.

No major comments from me other than adding a couple clarifications for install.

airbyte-ci/connectors/pipelines/CONTRIBUTING.md Outdated Show resolved Hide resolved
```


## Main libraries used in the tool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

As Dagger exposes async APIs we use `anyio` (and the `asyncer` wrapper sometimes) to benefit from [structured concurrency](https://en.wikipedia.org/wiki/Structured_concurrency).
**Reading the docs of these libraries is a must if you want to declare concurrent logics.**

## Design principles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

airbyte-ci/connectors/pipelines/CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Ben Church <ben@airbyte.io>
Co-authored-by: Cristina Mariscal <166420606+cmm-airbyte@users.noreply.github.com>
@alafanechere alafanechere merged commit 8aa506c into master Apr 24, 2024
36 checks passed
@alafanechere alafanechere deleted the augustin/04-24-airbyte-ci_add_a_contribution_guide branch April 24, 2024 17:44
Copy link
Contributor

@natikgadzhi natikgadzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alafanechere, I love the detailed explanation of basic building blocks.

FVidalCarneiro pushed a commit to AgiData/airbyte that referenced this pull request May 2, 2024
Co-authored-by: Ben Church <ben@airbyte.io>
Co-authored-by: Cristina Mariscal <166420606+cmm-airbyte@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants