-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unnecessary calls to toList() #37540
Merged
stephane-airbyte
merged 1 commit into
master
from
stephane/04-24-remove_unnecessary_calls_to_tolist_
May 23, 2024
Merged
remove unnecessary calls to toList() #37540
stephane-airbyte
merged 1 commit into
master
from
stephane/04-24-remove_unnecessary_calls_to_tolist_
May 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git βοΈ 1 Ignored Deployment
|
This was referenced Apr 24, 2024
2 tasks
51f0f84
to
6f29c47
Compare
8e16e1c
to
8ce5800
Compare
6f29c47
to
7214dad
Compare
8ce5800
to
153d867
Compare
7214dad
to
7c8644f
Compare
153d867
to
5d1b68b
Compare
2 tasks
7c8644f
to
871b988
Compare
5d1b68b
to
b3fd99e
Compare
871b988
to
741c4e0
Compare
2b8f4bb
to
e92ae48
Compare
741c4e0
to
c973ec7
Compare
e92ae48
to
a49d264
Compare
c973ec7
to
ce051da
Compare
a49d264
to
1921820
Compare
ce051da
to
cf6216b
Compare
1921820
to
33f3a50
Compare
cf6216b
to
bc2ce57
Compare
33f3a50
to
2fd07b2
Compare
bc2ce57
to
7b8866f
Compare
2fd07b2
to
2dfe157
Compare
6c67ee9
to
2134e41
Compare
a9ae0e8
to
5d48aec
Compare
2134e41
to
3c1eed3
Compare
5d48aec
to
e6ef20e
Compare
3c1eed3
to
0e31b09
Compare
e6ef20e
to
1a21a77
Compare
0e31b09
to
e2be9c5
Compare
1a21a77
to
57615ce
Compare
e2be9c5
to
86bc96e
Compare
57615ce
to
b126b06
Compare
86bc96e
to
f759d9a
Compare
b126b06
to
a7b52c0
Compare
edgao
approved these changes
May 23, 2024
"executing command %s", | ||
Strings.join(cmd.toList().asIterable(), " ") | ||
) | ||
String.format("executing command %s", Strings.join(cmd.asIterable(), " ")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: use kotlin string templating? (... or even just a string concat)
gisripa
approved these changes
May 23, 2024
Merge activity
|
a7b52c0
to
18103a0
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?