Exclude zookeeper dependencies #37584
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
|
The only test failure is a timeout 🤷 |
|
@evantahler you can use the @timeout annotation on the failing test to give it more time. That being said, I have seen several tests failing here and there with a 1minute timeout, but it should be set to 5 minutes by default... Might be worth investigation what's going on with that |
|
@stephane-airbyte where are we setting the 5 minute default? This line is setting 1 minute Line 185 in 9521749 (... I also have this PR #37494, where I set 5m for bigquery 9f95b29 |
|
thank you for keeping me honest @edgao . So default Timeout is one minute. The current timeout is odd because it seems to be "caused" by an image not found error from docker, which makes very little sense. 1) why would finding a docker image take over a minute and 2) why would it trigger a timeout rather than a proper ImageNotFoundException ??? I'm just going to re-run those tests for now |
| @@ -1 +1 @@ | |||
| version=0.30.11 | |||
| version=0.31.0 | |||
There was a problem hiding this comment.
Why the minor version bump?
Also please update the CDK changelog.
There was a problem hiding this comment.
I picked a minor bump because this removed a lot of transitive dependencies. I'm a little worried that something deep down was relying on on them, but I can't be sure (the tests pass... so yolo?)
There was a problem hiding this comment.
changelog bumped
|
Tests are passing - moving forward with the new CDK version and deploy |
|
/publish-java-cdk
|
Partially closes https://github.com/airbytehq/airbyte-internal-issues/issues/7245. We don't need zookeeper. This PR will need to bump the CDK and then connectors will have to update the version of the CDK they use.
That is blocked by upgrading destinations to the latest Kotlin CDK, e.g. #36899