Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📚 Update all Python connectors READMEs with minimum required version #3760

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

TymoshokDmytro
Copy link
Contributor

@TymoshokDmytro TymoshokDmytro commented May 31, 2021

What

#3579 Mention the exact minimum version of Python needed in all connector READMEs

How

Update python connectors READMEs with the line Minimum Python version required = 3.7.0

Pre-merge Checklist

Recommended reading order

All python READMEs in airbyte-integrations/connectors folder

@yaroslav-dudar
Copy link
Contributor

Hi @TymoshokDmytro I see that some doc files still have 3.7.9 version. Is it ok ?

grep -rl "3.7.9" --exclude-dir={node_modules,venv,.venv} --exclude="*.svg" ./docs/
./docs/.gitbook/assets/newsourcetutorial_plop.gif
./docs/contributing-to-airbyte/python/tutorials/cdk-tutorial-python-http/0-getting-started.md
./docs/understanding-airbyte/tech-stack.md
./docs/tutorials/transformation-and-normalization/transformations-with-dbt.md
./docs/tutorials/tutorials/build-a-connector-the-hard-way.md

some files in ./airbyte-integrations/bases/
./airbyte-integrations/bases/base-python/docs/tutorials/http_api_source.md

@TymoshokDmytro
Copy link
Contributor Author

TymoshokDmytro commented May 31, 2021

Hi @TymoshokDmytro I see that some doc files still have 3.7.9 version. Is it ok ?

grep -rl "3.7.9" --exclude-dir={node_modules,venv,.venv} --exclude="*.svg" ./docs/
./docs/.gitbook/assets/newsourcetutorial_plop.gif
./docs/contributing-to-airbyte/python/tutorials/cdk-tutorial-python-http/0-getting-started.md
./docs/understanding-airbyte/tech-stack.md
./docs/tutorials/transformation-and-normalization/transformations-with-dbt.md
./docs/tutorials/tutorials/build-a-connector-the-hard-way.md

some files in ./airbyte-integrations/bases/
./airbyte-integrations/bases/base-python/docs/tutorials/http_api_source.md

@yaroslav-dudar, thanks! Make updates to those files too.

@TymoshokDmytro TymoshokDmytro merged commit a1035e0 into master Jun 2, 2021
@TymoshokDmytro TymoshokDmytro deleted the dtymoshok/#3579-mention-py-version branch June 2, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention the exact minimum version of Python needed in all connector READMEs
3 participants