-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Source Amazon Ads: add info agency account to docs/spec/error messages #37655
Merged
darynaishchenko
merged 9 commits into
master
from
daryna/source-amazon-ads/agency-account
May 7, 2024
Merged
📝 Source Amazon Ads: add info agency account to docs/spec/error messages #37655
darynaishchenko
merged 9 commits into
master
from
daryna/source-amazon-ads/agency-account
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/amazon-ads
labels
Apr 29, 2024
askarpets
approved these changes
May 7, 2024
satish-chinthanippu
pushed a commit
to Teradata/airbyte
that referenced
this pull request
May 10, 2024
clnoll
pushed a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/amazon-ads
team/connectors-python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
oncall: https://github.com/airbytehq/oncall/issues/4529
Users with agency account cannot set up amazon ads source.
How
Updated spec/docs/error message with information regarding agency account and reason why we cannot use it for connections.
API docs
Review guide
User Impact
Users with agency account only will be able to understand the reason why the can't set up source and know what to do with it.
Can this PR be safely reverted and rolled back?