Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Source Amazon Ads: add info agency account to docs/spec/error messages #37655

Merged
merged 9 commits into from May 7, 2024

Conversation

darynaishchenko
Copy link
Collaborator

@darynaishchenko darynaishchenko commented Apr 29, 2024

What

oncall: https://github.com/airbytehq/oncall/issues/4529
Users with agency account cannot set up amazon ads source.

How

Updated spec/docs/error message with information regarding agency account and reason why we cannot use it for connections.
API docs

Review guide

User Impact

Users with agency account only will be able to understand the reason why the can't set up source and know what to do with it.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@darynaishchenko darynaishchenko self-assigned this Apr 29, 2024
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 10:57am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-ads labels Apr 29, 2024
@darynaishchenko darynaishchenko merged commit c9c5acb into master May 7, 2024
32 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-amazon-ads/agency-account branch May 7, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-ads team/connectors-python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants