Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose cdk version as airbyte_cdk.__version__ #37680

Merged
merged 1 commit into from Apr 30, 2024
Merged

Expose cdk version as airbyte_cdk.__version__ #37680

merged 1 commit into from Apr 30, 2024

Conversation

girarda
Copy link
Contributor

@girarda girarda commented Apr 29, 2024

What

Expose the CDK version as __version__.

Example usage:

python
Python 3.9.18 (main, Aug 24 2023, 21:19:58)
[Clang 14.0.3 (clang-1403.0.22.14.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import airbyte_cdk
>>> airbyte_cdk.__version__
'0.83.1'

If testing locally, you might have to delete your local airbyte_cdk.egg-info (rm -r airbyte_cdk.egg-info) because importlib uses that artefact.

How

importlib.metadata.version("airbyte_cdk")

User Impact

Users will be able to tell which version of the CDK they use from their Python environment

Can this PR be safely reverted and rolled back?

  • YES 馃挌

@girarda girarda requested a review from a team as a code owner April 29, 2024 23:28
@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

1 Ignored Deployment
Name Status Preview Updated (UTC)
airbyte-docs 猬滐笍 Ignored (Inspect) Apr 29, 2024 11:29pm

@octavia-squidington-iii octavia-squidington-iii added the CDK Connector Development Kit label Apr 29, 2024
@girarda girarda merged commit 102d09c into master Apr 30, 2024
34 checks passed
@girarda girarda deleted the alex/expose_cdk_version branch April 30, 2024 17:18
clnoll pushed a commit that referenced this pull request May 10, 2024
@girarda @clnoll
Expose cdk version as airbyte_cdk.__version__ (#37680)
addb338
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

Assignees
No one assigned
Labels
CDK Connector Development Kit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@girarda @erohmensing @octavia-squidington-iii