Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination Bigquery: Remove reference to TDValve #37714

Merged
merged 2 commits into from May 8, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented Apr 30, 2024

Bigquery never actually supported incremental T+D, but instantiated a valve anyway. Remove that field.

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 6:11pm

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Apr 30, 2024
Copy link
Contributor Author

edgao commented Apr 30, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @edgao and the rest of your teammates on Graphite Graphite

@edgao edgao force-pushed the edgao/kill_incremental_td branch from fb92c79 to 8e4b870 Compare May 3, 2024 22:20
@edgao edgao requested a review from a team as a code owner May 3, 2024 22:20
@edgao edgao force-pushed the edgao/bq_incremental_td branch from e0a629d to 8f95f23 Compare May 3, 2024 22:21
@edgao edgao force-pushed the edgao/kill_incremental_td branch 2 times, most recently from 464b3fc to 1325711 Compare May 7, 2024 22:27
@edgao edgao force-pushed the edgao/bq_incremental_td branch from 8f95f23 to 5cdcc77 Compare May 7, 2024 22:29
Base automatically changed from edgao/kill_incremental_td to master May 7, 2024 22:40
@edgao edgao force-pushed the edgao/bq_incremental_td branch from 5cdcc77 to 35637b5 Compare May 8, 2024 15:29
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 8, 2024
@edgao edgao enabled auto-merge (squash) May 8, 2024 15:49
@edgao edgao force-pushed the edgao/bq_incremental_td branch from a8278f6 to 98ec352 Compare May 8, 2024 18:07
@edgao edgao merged commit 47c86a9 into master May 8, 2024
34 of 35 checks passed
@edgao edgao deleted the edgao/bq_incremental_td branch May 8, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/bigquery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants