Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy metadata service on any changes to metadata service (including lib) #37717

Merged
merged 1 commit into from
May 1, 2024

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Apr 30, 2024

What

  • Close Deploy metadata service upon changes to lib #37681
  • The version bumping stuff i don't think should matter, as we both do a direct dev install and actually don't use the poetry lockfile (i forgot about this part - the thing we noticed where poetry2setup is actually more of a pyproject2setup and doesn't take into account the lockfile

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview Apr 30, 2024 5:53pm

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @erohmensing and the rest of your teammates on Graphite Graphite

@erohmensing erohmensing requested a review from bnchrch May 1, 2024 16:37
@erohmensing erohmensing marked this pull request as ready for review May 1, 2024 16:37
@erohmensing erohmensing requested a review from a team as a code owner May 1, 2024 16:37
@bnchrch
Copy link
Contributor

bnchrch commented May 1, 2024

speed-i-am-speed-gif

@erohmensing erohmensing merged commit a16b7eb into master May 1, 2024
33 checks passed
@erohmensing erohmensing deleted the ella/deployorch branch May 1, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy metadata service upon changes to lib
2 participants