🐛 Source Zendesk Support: add %Y-%m-%dT%H:%M:%S%z to cursor_datetime_formats #37723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
bazarnov
approved these changes
Apr 30, 2024
tolik0
reviewed
Apr 30, 2024
| @@ -85,6 +85,7 @@ definitions: | |||
| type: DatetimeBasedCursor | |||
| cursor_datetime_formats: | |||
| - "%Y-%m-%dT%H:%M:%SZ" | |||
| - "%Y-%m-%dT%H:%M:%S%z" | |||
There was a problem hiding this comment.
Should this cursor format also be added to audit_logs_stream and cursor_incremental_sync?
There was a problem hiding this comment.
it failed on ticket_forms stream, so I prefer do not change not affected streams.
There was a problem hiding this comment.
added to audit_logs_stream and cursor_incremental_sync
tolik0
approved these changes
Apr 30, 2024
darynaishchenko
deleted the
daryna/source-zendesk-support/add-datetime-formats
branch
clnoll
pushed a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
oncall https://github.com/airbytehq/oncall/issues/5169
How
Added %Y-%m-%dT%H:%M:%S%z to cursor_datetime_formats
Review guide
User Impact
Can this PR be safely reverted and rolled back?