airbyte-ci: reduce required env var when running in CI #37765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alafanechere and the rest of your teammates on |
alafanechere
force-pushed
the
augustin/05-02-airbyte-ci_reduce_required_env_var_when_running_in_CI
branch
2 times, most recently
from
0a76d2f
to
9c533f2
Compare
alafanechere
force-pushed
the
augustin/05-02-airbyte-ci_reduce_required_env_var_when_running_in_CI
branch
from
9c533f2
to
5329b0b
Compare
alafanechere
deleted the
augustin/05-02-airbyte-ci_reduce_required_env_var_when_running_in_CI
branch
clnoll
pushed a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run "early CI" on community PR we have to make some env vars with secret values optionals.
This PR removes the requirement for the following env vars in CI:
If
CI_REPORT_BUCKET_NAMEis not set reports will simply not be uploaded to GCS, which is fine as they are attached as artifacts to worfklow runs.If
GCP_GSM_CREDENTIALSis not set the test pipeline won't be able to fetch our sandbox credentials. Which is fine in "early CI" as we're not running steps that require secret access.