Source FB Marketing: Handle errors without API Error Code/Messages #37771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
octavia-squidington-iii
added
the
area/documentation
cmm-airbyte
approved these changes
May 6, 2024
cmm-airbyte
reviewed
May 6, 2024
...ntegrations/connectors/source-facebook-marketing/source_facebook_marketing/streams/common.py
Outdated
Show resolved
Hide resolved
cmm-airbyte
reviewed
May 6, 2024
airbyte-integrations/connectors/source-facebook-marketing/unit_tests/test_errors.py
Outdated
Show resolved
Hide resolved
….com/airbytehq/airbyte into christo/facebook-marketing-503-error
…ce_facebook_marketing/streams/common.py Co-authored-by: Aldo Gonzalez <168454423+aldogonzalez8@users.noreply.github.com>
satish-chinthanippu
pushed a commit
to Teradata/airbyte
that referenced
this pull request
May 10, 2024
clnoll
pushed a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes syncs breaking on 503 errors due to the error handling expecting all
FacebookRequestErrorsto contain anapi_error_message, resulting in aTypeErrorbeing thrown when the value ofapi_error_messageisNone.Resolves: https://github.com/airbytehq/airbyte-internal-issues/issues/7349
How
traced_exceptionmethod to handleFacebookRequestErrorsthat do not include anapi_error_messageby using the error'sget_messageas a fallback.Review guide
User Impact
503 errors will be retried and thrown as transient errors if they are not resolved on retry. Any other errors without
api_error_messageshould no longer throw a TypeError, and be raised as TracedExceptions containing the actual error.Can this PR be safely reverted and rolled back?