Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

airbyte-ci: reduce required env var when running in CI (fixed) #37786

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented May 2, 2024

Reading the self.ci_gcs_credentials_secret property in a context before the Dagger client instantiation led to AssertionError: The dagger client was not set on this PipelineContext.
This property used the self.dagger_client but it was used by self.remote_storage_enabled in a code path where the dagger client was not set on the PipelineContext.

Fixing it by accessing self.ci_gcs_credentials instead of self.ci_gcs_credentials_secret in the self.remote_storage_enabled property.

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 7:27am

Copy link

sentry-io bot commented May 2, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: airbyte-ci/connectors/pipelines/pipelines/models/contexts/pipeline_context.py

Function Unhandled Issue
github_commit_status AssertionError: The dagger client was not set on this PipelineContext pipelines.models.contexts.pipeline_con...
Event Count: 44

Did you find this useful? React with a 👍 or 👎

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere force-pushed the augustin/05-02-airbyte-ci_reduce_required_env_var_when_running_in_CI_fixed_ branch from 422248e to ff5851a Compare May 2, 2024 19:29
@alafanechere alafanechere marked this pull request as ready for review May 3, 2024 07:13
@alafanechere alafanechere requested a review from a team as a code owner May 3, 2024 07:13
@alafanechere alafanechere force-pushed the augustin/05-02-airbyte-ci_reduce_required_env_var_when_running_in_CI_fixed_ branch from 59756ee to 8b0142d Compare May 3, 2024 07:27
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label May 3, 2024
@alafanechere alafanechere merged commit d93fcfd into master May 3, 2024
34 of 35 checks passed
@alafanechere alafanechere deleted the augustin/05-02-airbyte-ci_reduce_required_env_var_when_running_in_CI_fixed_ branch May 3, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants