Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle.yml: make it run on forks #37788

Merged

Conversation

alafanechere
Copy link
Contributor

@alafanechere alafanechere commented May 3, 2024

The gradle.yml workflow has a required Gradle Check job. If we want to accept contributions from forks on Java connectors we should make it run on forks.
It should be possible as this workflow does not require secret access.
On forks the workflow will not benefit from our S3 gradle cache nor docker login, it might have a performance impact but its tolerable given the small amount of java connectors contribution.

@alafanechere alafanechere requested a review from a team as a code owner May 3, 2024 08:40
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 3, 2024 8:46am

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alafanechere and the rest of your teammates on Graphite Graphite

@alafanechere alafanechere force-pushed the augustin/05-03-gradle.yml_make_it_run_on_forks branch from 56ba777 to 27b3fd1 Compare May 3, 2024 08:46
@octavia-squidington-iii octavia-squidington-iii removed the area/connectors Connector related issues label May 3, 2024
@alafanechere alafanechere merged commit f9a6acb into master May 3, 2024
31 checks passed
@alafanechere alafanechere deleted the augustin/05-03-gradle.yml_make_it_run_on_forks branch May 3, 2024 08:52
aasimsani pushed a commit to taxwire/airbyte that referenced this pull request May 6, 2024
clnoll pushed a commit that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants