Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source File: add engine fastparquet to parquet reader options #37799

Merged
merged 4 commits into from
May 7, 2024

Conversation

darynaishchenko
Copy link
Collaborator

@darynaishchenko darynaishchenko commented May 3, 2024

What

oncall: https://github.com/airbytehq/oncall/issues/5111
Check process exit code is: 137.

How

Added fastparquet for parquet reader. Memory usage decreased to 174.9453125 MB, without option reader memory usage was 1051.77734375 MB.

Updated pandas to 1.5.0 as previous version is not compatible with latest fastparquet.

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@darynaishchenko darynaishchenko self-assigned this May 3, 2024
Copy link

vercel bot commented May 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 10:47am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/file labels May 3, 2024
@darynaishchenko darynaishchenko changed the title 🐛 Source File: add fastparquet for parquet reader 🐛 Source File: add engine fastparquet to parquet reader options May 3, 2024
@darynaishchenko darynaishchenko requested a review from a team May 3, 2024 16:10
@@ -21,7 +21,7 @@ html5lib = "==1.1"
beautifulsoup4 = "==4.11.1"
openpyxl = "==3.0.10"
google-cloud-storage = "==2.5.0"
pandas = "==1.4.3"
pandas = "1.5.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use the latest version of pandas in this connector?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated pandas to latest version

@darynaishchenko darynaishchenko force-pushed the daryna/source-file/memory-error branch from 9eb0d66 to ef4011a Compare May 7, 2024 10:47
@darynaishchenko darynaishchenko merged commit 395effc into master May 7, 2024
31 checks passed
@darynaishchenko darynaishchenko deleted the daryna/source-file/memory-error branch May 7, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants