Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Amazon SP: Add missing files #3782

Merged
merged 7 commits into from
Jun 1, 2021
Merged

Source Amazon SP: Add missing files #3782

merged 7 commits into from
Jun 1, 2021

Conversation

Zirochkaa
Copy link
Contributor

@Zirochkaa Zirochkaa commented Jun 1, 2021 •
edited
Loading

Add files for publishing the connector.
Update typing in few files.
Add amazon-seller-partner.md file.
Add Amazon Seller Partner to builds.md and to README.md files.

Pre-merge Checklist

  • Run integration tests
  • Publish Docker images

@Zirochkaa
Add missing files
20b7fb0 
Add files for publishing the connector.
Update typing in few files.
Add `amazon-seller-partner.md` file.
Add `Amazon Seller Partner` to `builds.md` and to `README.md` files.
@Zirochkaa Zirochkaa self-assigned this Jun 1, 2021
@Zirochkaa Zirochkaa changed the title Add missing files Source Amazon SP: Add missing files Jun 1, 2021
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Jun 1, 2021 •
edited by github-actions bot
Loading

/test connector=source-amazon-seller-partner

🕑 source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/896376426
❌ source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/896376426

@Zirochkaa Zirochkaa linked an issue Jun 1, 2021 that may be closed by this pull request
Release Amazon SP API connector #3774
Closed
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Jun 1, 2021 •
edited by github-actions bot
Loading

/test connector=source-amazon-seller-partner

🕑 source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/896398687
❌ source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/896398687

@Zirochkaa
Comment out tests in acceptance-test-config.yml
4e63037
@Zirochkaa
Update few files
a8db34a 
Remove `!Dockerfile.test` from `.dockerignore` file.
Add `dependencies` to `build.gradle` file.
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Jun 1, 2021 •
edited by github-actions bot
Loading

/test connector=source-amazon-seller-partner

🕑 source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/896696983
✅ source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/896696983

sherifnada
sherifnada approved these changes Jun 1, 2021
View reviewed changes
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one comment

docs/integrations/sources/amazon-seller-partner.md Show resolved Hide resolved
@Zirochkaa
Add stream to docs
63f6b68 
Add `GET_FLAT_FILE_ALL_ORDERS_DATA_BY_ORDER_DATE_GENERAL` stream.
@Zirochkaa
Add release info
e02e301 
Add connector to `source_definitions.yaml` file.
Add connector to `STANDARD_SOURCE_DEFINITION` folder.
@Zirochkaa
Copy link
Contributor Author

Zirochkaa commented Jun 1, 2021 •
edited by github-actions bot
Loading

/publish connector=connectors/source-amazon-seller-partner

🕑 connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/897193029
✅ connectors/source-amazon-seller-partner https://github.com/airbytehq/airbyte/actions/runs/897193029

@Zirochkaa Zirochkaa merged commit 4b3e345 into master Jun 1, 2021
@Zirochkaa Zirochkaa deleted the oleh/3774-release-amazon-sp-connector branch June 1, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherifnada sherifnada sherifnada approved these changes

@keu keu Awaiting requested review from keu

@vitaliizazmic vitaliizazmic Awaiting requested review from vitaliizazmic

@yevhenii-ldv yevhenii-ldv Awaiting requested review from yevhenii-ldv

Assignees

@Zirochkaa Zirochkaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release Amazon SP API connector
2 participants
@Zirochkaa @sherifnada