Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Add Airbyte-native shopify connector (replaces Singer-based) #3787

Merged
merged 60 commits into from
Jun 8, 2021

Conversation

bazarnov
Copy link
Collaborator

@bazarnov bazarnov commented Jun 1, 2021

What

#3581 new source: Airbyte-native Shopify connector

How

Using Airbyte's Python CDK, implemented the logic for source-shopify connector, with the same endpoint as shopify-singer connector has.
By default, it pulls out all the data, then keeps it fresh using the incremental refresh (incremental should be selected as an option inside connection settings)

Pre-merge Checklist

Expand the checklist which is relevant for this PR.

Connector checklist

  • Issue acceptance criteria met
  • Unit & integration tests added as appropriate (and are passing)
  • /test command documented here is passing.
  • Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
  • Code reviews completed
  • Documentation updated
    • README
    • Reference docs in the docs/integrations/ directory.
  • Build is successful
  • Connector version bumped like described here
  • New Connector version released on Dockerhub by running the /publish command described here
  • No major blockers
  • PR merged into master branch
  • Follow up tickets have been created
  • Associated tickets have been closed & stakeholders notified

File doesn't need
@bazarnov bazarnov changed the title first commit bazarnov/3581-shopify-cdk-connector Jun 2, 2021
@bazarnov bazarnov requested a review from tuliren June 3, 2021 11:32
@bazarnov bazarnov linked an issue Jun 3, 2021 that may be closed by this pull request
@bazarnov
Copy link
Collaborator Author

bazarnov commented Jun 6, 2021

@bazarnov can you fix the PR diff?

Fixed.

Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question and one suggestion, almost there!

Also a couple of comments:

  1. you should edit the repo's root .gitignore to ignore the files which messed up the PR diff so you don't have this issue in the future
  2. in the future make sure to wait for a PR approval to run the publish command ;)

@bazarnov
Copy link
Collaborator Author

bazarnov commented Jun 7, 2021

/test connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/913895740
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/913895740

@bazarnov bazarnov requested a review from sherifnada June 7, 2021 08:23
@bazarnov bazarnov force-pushed the bazarnov/3581-shopify-cdk-connector branch 2 times, most recently from 5663e2e to e1b4473 Compare June 7, 2021 09:47
@bazarnov bazarnov changed the title bazarnov/3581-shopify-cdk-connector 🎉 bazarnov/3581-shopify-cdk-connector Jun 7, 2021
Copy link
Contributor

@sherifnada sherifnada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🚢 🚢 🚢 🚢

@bazarnov bazarnov force-pushed the bazarnov/3581-shopify-cdk-connector branch from 0206329 to e1b4473 Compare June 7, 2021 15:07
@bazarnov
Copy link
Collaborator Author

bazarnov commented Jun 7, 2021

/publish connector=connectors/source-shopify

🕑 connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/915337189
✅ connectors/source-shopify https://github.com/airbytehq/airbyte/actions/runs/915337189

@bazarnov bazarnov changed the title 🎉 bazarnov/3581-shopify-cdk-connector 🎉 Add Airbyte-native shopify connector (replaces Singer-based) Jun 7, 2021
@bazarnov bazarnov merged commit 01dc7bb into master Jun 8, 2021
@bazarnov bazarnov deleted the bazarnov/3581-shopify-cdk-connector branch June 8, 2021 09:46
@jacqueskpoty
Copy link
Contributor

Bravo!!! for this new connector. It makes life much easier. I love the fact that it does not even use the Shopify CDK and uses the API endpoints directly. I tested it and its working perfectly for me. I'm going to add a couple of endpoints that my team needs into it as described in the following issue #3576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🎉 new source: Airbyte-native Shopify connector
5 participants