Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectors-qa] Remove unrelated docs check #38018

Merged
merged 1 commit into from May 8, 2024

Conversation

natikgadzhi
Copy link
Contributor

What

This PR only removes a check of whether docs exist for a connector in MetadataCheck, because it's already validated in DocumentationCheck.

It's extracted from #38017.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@natikgadzhi natikgadzhi requested a review from a team as a code owner May 7, 2024 10:29
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 10:42am

@natikgadzhi natikgadzhi enabled auto-merge (squash) May 7, 2024 10:29
@natikgadzhi
Copy link
Contributor Author

This should be fine — set to automerge.

@natikgadzhi natikgadzhi requested a review from bnchrch May 7, 2024 13:45
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

@natikgadzhi natikgadzhi merged commit 8d914d9 into master May 8, 2024
30 checks passed
@natikgadzhi natikgadzhi deleted the ng/connectors_qa/metadata-no-docs-check branch May 8, 2024 15:40
satish-chinthanippu pushed a commit to Teradata/airbyte that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants