CDK changes for destination-databricks #38095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
gisripa
force-pushed
the
gireesh/05-09-gireesh/cdk-dbricks
branch
from
41160c4
to
189d2a6
Compare
| @@ -440,7 +441,16 @@ constructor( | |||
| Instant.ofEpochMilli(Long.MIN_VALUE) | |||
| } else { | |||
| try { | |||
| Instant.parse(node.asText()) | |||
There was a problem hiding this comment.
not a massive fan. Any reason DatabricksDestination can't override this class?
There was a problem hiding this comment.
Too much plumbing into BaseTypingDedupingTest and lot of copy-paste
gisripa
force-pushed
the
gireesh/05-09-gireesh/cdk-dbricks
branch
3 times, most recently
from
0b2620d
to
90a8953
Compare
gisripa
force-pushed
the
gireesh/05-09-gireesh/cdk-dbricks
branch
from
90a8953
to
ffd9ee6
Compare
edgao
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review guide
User Impact
Can this PR be safely reverted and rolled back?