-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination e2e test: enable dedup #38097
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fake connector faking deduplication? Love to see it.
@@ -3,7 +3,7 @@ | |||
"supportsIncremental": true, | |||
"supportsNormalization": false, | |||
"supportsDBT": false, | |||
"supported_destination_sync_modes": ["overwrite", "append"], | |||
"supported_destination_sync_modes": ["overwrite", "append", "append_dedup"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WOOHOO!
@timroes we'll be able to test both refresh modes in the UI now 😄
.... how are tests failing, this connector does literally nothing |
/format-fix
|
tag destination-e2e as supporting dedup, so that we can use it for more testing things