Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination e2e test: enable dedup #38097

Merged
merged 4 commits into from May 9, 2024
Merged

Destination e2e test: enable dedup #38097

merged 4 commits into from May 9, 2024

Conversation

edgao
Copy link
Contributor

@edgao edgao commented May 9, 2024

tag destination-e2e as supporting dedup, so that we can use it for more testing things

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
airbyte-docs ⬜️ Ignored (Inspect) Visit Preview May 9, 2024 8:35pm

@edgao edgao marked this pull request as ready for review May 9, 2024 19:55
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label May 9, 2024
@edgao edgao requested review from teallarson and a team May 9, 2024 19:56
Copy link
Contributor

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fake connector faking deduplication? Love to see it.

@@ -3,7 +3,7 @@
"supportsIncremental": true,
"supportsNormalization": false,
"supportsDBT": false,
"supported_destination_sync_modes": ["overwrite", "append"],
"supported_destination_sync_modes": ["overwrite", "append", "append_dedup"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

Copy link
Contributor

@teallarson teallarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOHOO!
@timroes we'll be able to test both refresh modes in the UI now 😄

@edgao edgao enabled auto-merge (squash) May 9, 2024 20:01
@edgao
Copy link
Contributor Author

edgao commented May 9, 2024

.... how are tests failing, this connector does literally nothing

@edgao
Copy link
Contributor Author

edgao commented May 9, 2024

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (6ba1d83)

@edgao edgao merged commit 4c7ebfa into master May 9, 2024
33 checks passed
@edgao edgao deleted the edgao/e2e_dedup branch May 9, 2024 20:44
satish-chinthanippu pushed a commit to Teradata/airbyte that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/e2e-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants